Skip to content

[Doctrine] Slave/Master configuration options #7111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Nov 2, 2016

Like settled in the Configuration Class options keep_slave should be a children of connections

edit : preview : http://pr-7111-scvfh6y-6qmocelev2lwe.eu.platform.sh/reference/configuration/doctrine.html

Like settle in the configuration options keep_slave should be a children of connections
@Simperfit Simperfit changed the base branch from 2.7 to master November 2, 2016 18:42
@@ -406,7 +408,6 @@ The following block shows all possible configuration keys:
types:
custom: Acme\HelloBundle\MyCustomType
# the DBAL keepSlave option
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment must be moved too

@Simperfit
Copy link
Contributor Author

@xabbuh comment taken in account

@javiereguiluz
Copy link
Member

👍

@xabbuh
Copy link
Member

xabbuh commented Nov 5, 2016

Thank you @Simperfit.

xabbuh added a commit that referenced this pull request Nov 5, 2016
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #7111).

Discussion
----------

[Doctrine] Slave/Master configuration options

Like settled in the [Configuration Class](https://github.com/doctrine/DoctrineBundle/blob/master/DependencyInjection/Configuration.php#L149) options keep_slave should be a children of connections

edit : preview : http://pr-7111-scvfh6y-6qmocelev2lwe.eu.platform.sh/reference/configuration/doctrine.html

Commits
-------

2a38145 [Doctrine] Slave/Master configuration options
@xabbuh xabbuh closed this Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants